Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle size increase in v1.1.0 because of inlining graphiql #26

Closed
kamilkisiela opened this issue Mar 24, 2021 · 3 comments
Closed

Bundle size increase in v1.1.0 because of inlining graphiql #26

kamilkisiela opened this issue Mar 24, 2021 · 3 comments

Comments

@kamilkisiela
Copy link
Collaborator

kamilkisiela commented Mar 24, 2021 •
edited

@danielrearden hello
a234865 this change adds 1mb to overall bundle size https://unpkg.com/browse/graphql-helix@1.1.0/dist/
@kamilkisiela
Copy link
Collaborator Author

Not sure if it's expected so I'm just leaving it here as an issue.

@kamilkisiela kamilkisiela changed the title Bundle size increase in v1.1.0 Bundle size increase in v1.1.0 because of inlining graphiql Mar 24, 2021
@orefalo
Copy link

orefalo commented Mar 29, 2021

I personally use altair, much clearer UI

@danielrearden
Copy link
Contributor

This is to be expected. I think #9 will address this in the sense that the entire renderGraphiQL function will live in its own package separate from the core functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orefalo @kamilkisiela @danielrearden