Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisted query examples appear to be incorrect #40

Open
b-jsshapiro opened this issue Jul 6, 2021 · 2 comments
Open

Persisted query examples appear to be incorrect #40

b-jsshapiro opened this issue Jul 6, 2021 · 2 comments

Comments

@b-jsshapiro
Copy link

Both examples work fine if the query has previously been persisted, but neither appears to handle the case where we are seeing a query for the first time that needs to be persisted for future use....

@StarpTech
Copy link

Hi, I also want to mention that the phrase is wrong

Persisted queries are also a performance optimization since they allow us to skip parsing the query when executing a request.

Wen can't skip the parsing mechanism. The query string is just looked up from the cache rather than from the request.

@StarpTech
Copy link

@b-jsshapiro This is just an example and is no complete implementation. For reference you could check out https://github.com/StarpTech/GraphCDN/blob/main/src/routes/apq.ts#L29-L104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants