fix(git-client): match semver better in unstable tag regex #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulqu
force-pushed
the
unstableTagRegexFix
branch
from
d9935d8
to
c45d8c1
Compare
|
@Rulqu Thank you! please add test case for these changes |
|
@dangreen I don't have any experience in how to do tests. I'm just a devops who wanted to use this tool and knew a bit of regex. I could learn but I don't really know how to start. |
|
@Rulqu Looks like your regex is incorrect. Please see tests result |
Rulqu
force-pushed
the
unstableTagRegexFix
branch
from
c45d8c1
to
4e48728
Compare
Rulqu
force-pushed
the
unstableTagRegexFix
branch
from
4e48728
to
5332bca
Compare
|
@dangreen Ah, I figured out how the testing works here. I guess I didn't research enough. I fixed the regex and added some entries to the test that failed before my fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1276
Fixes #935