Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published date does not work #967

Open
slightlychilled opened this issue Apr 8, 2020 · 3 comments
Open

Published date does not work #967

slightlychilled opened this issue Apr 8, 2020 · 3 comments
Labels

Comments

@slightlychilled
Copy link

When changing the published date, it's not possible to select a new date, only a time.

@rchavik
Copy link
Member

rchavik commented Apr 8, 2020

Are you using Chrome? Can you open up dev tools and confirm that there are script errors there?

It's likely that we need to adjust Core/src/Template/Element/admin/javascripts.ctp

@rchavik rchavik added the Defect label Apr 8, 2020
@rchavik
Copy link
Member

rchavik commented Apr 8, 2020

Can you try with the following change:

diff --git a/Core/src/Template/Element/admin/javascripts.ctp b/Core/src/Template/Element/admin/javascripts.ctp
index 7e753793..d5437e2f 100644
--- a/Core/src/Template/Element/admin/javascripts.ctp
+++ b/Core/src/Template/Element/admin/javascripts.ctp
@@ -9,23 +9,23 @@ if (!$this->getRequest()->is('ajax')) :
     ]);
     echo $this->Html->script([
         'Croogo/Core.jquery/jquery-ui.min.js',
-        'Croogo/Core.core/popper.min.js',
-        'Croogo/Core.core/bootstrap.min.js',
         'Croogo/Core.jquery/jquery.slug',
         'Croogo/Core.jquery/jquery.hoverIntent.minified',
         'Croogo/Core.core/bootstrap3-typeahead.min',
         'Croogo/Core.core/moment-timezone-with-data',
-        'Croogo/Core.core/tempusdominus-bootstrap-4.min',
         'Croogo/Core.core/typeahead_autocomplete',
         'Croogo/Core.core/ekko-lightbox.min.js',
         'Croogo/Core.core/select2.full.min.js',
-        'Croogo/Core.core/sidebar',
         'Croogo/Core.core/choose',
-        'Croogo/Core.core/modal',
     ], [
         'async' => true,
     ]);
     echo $this->Html->script([
+        'Croogo/Core.core/popper.min.js',
+        'Croogo/Core.core/bootstrap.min.js',
+        'Croogo/Core.core/tempusdominus-bootstrap-4.min',
+        'Croogo/Core.core/sidebar',
+        'Croogo/Core.core/modal',
         'Croogo/Core.core/admin',
     ], [
         'defer' => true,

@sitedyno
Copy link
Contributor

The patch above fixed the following issue for me on 4.0.7.

  • I would copy a node.
  • The new node would appear.
  • There would be a console error:
jquery.min.js?1580078064:2 Uncaught TypeError: $(...).tooltip is not a function
    at Object.Admin.form (admin.js?1626477085:34)
    at HTMLDocument.<anonymous> (nodes:319)
    at j (jquery.min.js?1580078064:2)
    at k (jquery.min.js?1580078064:2)
  • The sidebar no longer worked.
  • Any button that caused an ajax request no longer worked.

Thanks.

sitedyno added a commit to sitedyno/croogo that referenced this issue Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants