Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release #11

Open
iamvdo opened this issue Mar 27, 2015 · 4 comments
Open

Next release #11

iamvdo opened this issue Mar 27, 2015 · 4 comments

Comments

@iamvdo
Copy link
Collaborator

iamvdo commented Mar 27, 2015

Hey!

I've just created a sourcemaps branch with many improvements about, well... sourcemaps, but not only:

  • dealing with multiple input files
  • dealing with preprocessors easily, since they are included in pleeease

I've also added more tests, and add some of them in the README.

Can you please review this branch, and give feedback ?
It's the first time I contribute to a gulp plugin, so I may be wrong.

Thanks! 👍

@danielhusar
Copy link
Owner

Hey,

cheers.
I might not get into this today, but I will definitely take a look during the weekend.
You can create a PR from this branch, its easier to review :)

@iamvdo
Copy link
Collaborator Author

iamvdo commented Mar 27, 2015

I've created PR, but I've made (too?) many changes. :)
Plus, tests fail. :/

@adamjohnson
Copy link

When I run gulp css, it looks like pxrem blows up. Here are my source files:

http://cl.ly/aQwK

pxrem-pleeeease-error

If you can't reproduce this, feel free to correct me.

@iamvdo
Copy link
Collaborator Author

iamvdo commented Mar 27, 2015

It was a pixrem bug. Fixed in 1.2.3.
Now it works. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants