You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all thank you for maintaining this project, I only recently gave it another try and I'm really happy with it for the most part (My favorite font is Gadugi).
1. Gradients/Backgrounds
I have recently submitted a change for elitepvpers.com. This is a fairly old website that uses images to implement gradients (possibly backgrounds in general). This used to be a much more common technique in the past and is still used on legacy sites today.
When using a dark mode (I'm specifically using dynamic mode - I think this is the main way to use the extension for most users?) on these sites, this technique usually causes the original gradient to be preserved and very flashy and annoyingly bleeding into the content above.
I had a few ideas how this could be fixed in general:
These gradient images usually have a 1:N aspect ratio, where N >> 1.
In order to repeat these images certain CSS attributes are necessary.
Specifically elitepvpers.com uses a forum software called vBulletin.
This forum software used to be a popular (if not the go-to) for communities in the time from 200X-201Y.
Detection of this forum software could possibly be implemented by detecting the HTML tag <style type="text/css" id="vbulletin_css"> or by other metrics and a "beta" version could then be field-tested in that subset of legacy sites first to see if there's any issues.
I haven't done much research and due diligence on this yet, as I first wanted to see, if this is something you are even interested in or if this is completely out of scope.
2. Dynamic fixes - color scheme
In 837f95f I had to replace one of these backgrounds and wanted to visually differentiate it from the rest of the background.
As far as I could tell there are only limited ways to control the colors in a dynamic theme fix in a color scheme aware way, namely:
${initial_color} !important
--darkreader-neutral-background
--darkreader-neutral-text
--darkreader-selection-background
--darkreader-selection-text
Is there any other way to replace something with a theme aware color? The way I ended up doing it for this specific site was the following:
Maybe it could be nice to have global variables to be available for use by contributors that interpolates between --darkreader-neutral-background and --darkreader-neutral-text, to offer different shades of the theme background.
Maybe something like --darkreader-background-lighter-10, --darkreader-background-lighter-20, etc. depending on the percentage of how much it should be brightened using the text color.
I'm happy to contribute and help but I mainly do C++/Rust so I'm not really experienced with JavaScript.
Thank you for taking the time to read and consider my discussion.
3. Replacing images with emojis
Is it possible/in-scope to replace images with annoying white pixels on legacy sites with emojis (possibly through emojistatic)
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
First of all thank you for maintaining this project, I only recently gave it another try and I'm really happy with it for the most part (My favorite font is Gadugi).
1. Gradients/Backgrounds
I have recently submitted a change for elitepvpers.com. This is a fairly old website that uses images to implement gradients (possibly backgrounds in general). This used to be a much more common technique in the past and is still used on legacy sites today.
When using a dark mode (I'm specifically using dynamic mode - I think this is the main way to use the extension for most users?) on these sites, this technique usually causes the original gradient to be preserved and very flashy and annoyingly bleeding into the content above.
I had a few ideas how this could be fixed in general:
1:N
aspect ratio, whereN >> 1
.Specifically elitepvpers.com uses a forum software called vBulletin.
This forum software used to be a popular (if not the go-to) for communities in the time from
200X
-201Y
.Detection of this forum software could possibly be implemented by detecting the HTML tag
<style type="text/css" id="vbulletin_css">
or by other metrics and a "beta" version could then be field-tested in that subset of legacy sites first to see if there's any issues.I haven't done much research and due diligence on this yet, as I first wanted to see, if this is something you are even interested in or if this is completely out of scope.
2. Dynamic fixes - color scheme
In 837f95f I had to replace one of these backgrounds and wanted to visually differentiate it from the rest of the background.
As far as I could tell there are only limited ways to control the colors in a dynamic theme fix in a color scheme aware way, namely:
${initial_color} !important
--darkreader-neutral-background
--darkreader-neutral-text
--darkreader-selection-background
--darkreader-selection-text
Is there any other way to replace something with a theme aware color? The way I ended up doing it for this specific site was the following:
darkreader/src/config/dynamic-theme-fixes.config
Line 8724 in 837f95f
Maybe it could be nice to have global variables to be available for use by contributors that interpolates between
--darkreader-neutral-background
and--darkreader-neutral-text
, to offer different shades of the theme background.Maybe something like
--darkreader-background-lighter-10
,--darkreader-background-lighter-20
, etc. depending on the percentage of how much it should be brightened using the text color.I'm happy to contribute and help but I mainly do C++/Rust so I'm not really experienced with JavaScript.
Thank you for taking the time to read and consider my discussion.
3. Replacing images with emojis
Is it possible/in-scope to replace images with annoying white pixels on legacy sites with emojis (possibly through emojistatic)
Beta Was this translation helpful? Give feedback.
All reactions