Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dfx commands for safety and mainnet #1777

Open
2 tasks
lastmjs opened this issue May 7, 2024 · 0 comments
Open
2 tasks

update dfx commands for safety and mainnet #1777

lastmjs opened this issue May 7, 2024 · 0 comments
Assignees
Milestone

Comments

@lastmjs
Copy link
Member

lastmjs commented May 7, 2024

Let's make sure that all dfx commands that need it will work on mainnet by adding the --network option (look at other places that we have already done this). Also we should probably not use the canister name but the canister id in our dfx commands, and we might want to get that from the CANISTER_ID whatever it is called environment variable.

  • are we sure that the authenticated file uploader will work in production? addController doesn't seem like it will work. We need to make sure that all functions in the dfx directory will work in production
  • Are we sure we should be using canister names for our dfx operations? It seems much safer to use canister ids,
@lastmjs lastmjs added this to the Q2 2024 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants