Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI arguments appear to not be properly typed #418

Open
seawatts opened this issue Dec 13, 2017 · 2 comments
Open

CLI arguments appear to not be properly typed #418

seawatts opened this issue Dec 13, 2017 · 2 comments
Labels
good first issue package:commands

Comments

@seawatts
Copy link
Contributor

https://github.com/denali-js/denali/blob/82401b4517b94426c3d723981eafad6356fd39cf/commands/server.ts#L98
@knownasilya
Copy link
Member

Args are always strings, so we need to do an explicit check here.

@davewasmer
Copy link
Collaborator

This line should be converting the arg to a typed variable. Perhaps this is a larger bug.

https://github.com/denali-js/denali/blob/82401b4517b94426c3d723981eafad6356fd39cf/commands/server.ts#L51

Updating the title to reflect

@davewasmer davewasmer changed the title When passing in false to watch it still watches CLI arguments appear to not be properly typed Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue package:commands
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@knownasilya @davewasmer @seawatts