Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Encoding Parameters #3

Open
kristoferbaxter opened this issue Jan 23, 2018 · 2 comments
Open

Support Encoding Parameters #3

kristoferbaxter opened this issue Jan 23, 2018 · 2 comments

Comments

@kristoferbaxter
Copy link

Hello!

I recently attempted to move over from iltorb to wasm-brotli and noticed that there is no current way to supply encoding parameters.

https://github.com/MayhemYDG/iltorb#brotliencodeparams

Is there planned support?
@kristoferbaxter kristoferbaxter mentioned this issue Jan 23, 2018
Open
@dfrankland
Copy link
Owner

Yes, they're sure is!

We need to think about how to make it ergonomic to give options to the WASM module. I am thinking that wasm-brotli will accept an options object, but all of the options will be given as strings to the WASM module to stay C-ABI safe.

@dfrankland dfrankland mentioned this issue Jan 24, 2018
Open
@kristoferbaxter kristoferbaxter mentioned this issue Mar 13, 2018
Closed
@jimmywarting
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kristoferbaxter @jimmywarting @dfrankland