Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid "please" in docs and messages #770

Closed
thaJeztah opened this issue Dec 28, 2017 · 2 comments · Fixed by #5141
Closed

Avoid "please" in docs and messages #770

thaJeztah opened this issue Dec 28, 2017 · 2 comments · Fixed by #5141
Labels
kind/docs

Comments

@thaJeztah
Copy link
Member

We should try to avoid using "please" in the documentation and in (error) messages. There's a couple in this repository that may need some rephrasing; https://github.com/docker/cli/search?q=please&type=Code&utf8=✓ (also see #721 (comment))

See;

/cc @mistyhacks
@thaJeztah thaJeztah mentioned this issue Dec 28, 2017
Merged
@thaJeztah thaJeztah mentioned this issue May 15, 2018
Merged
@thaJeztah thaJeztah mentioned this issue Sep 20, 2018
Merged
@thaJeztah thaJeztah mentioned this issue Feb 26, 2019
Merged
@thaJeztah thaJeztah mentioned this issue Jan 13, 2020
Merged
@ggracechoi
Copy link
Contributor

ggracechoi commented Apr 25, 2024 •
edited

Hi @thaJeztah! I'm a student at UT Austin, and I'm looking to contribute to an open source project for my Virtualization class. Is this issue still available? If not, do you think I'd be able to take on issue #923? I tried reaching out to @kolyshkin but wasn't able to get in contact.

@kolyshkin
Copy link
Contributor

Hi @thaJeztah! I'm a student at UT Austin, and I'm looking to contribute to an open source project for my Virtualization class. Is this issue still available? If not, do you think I'd be able to take on issue #923? I tried reaching out to @kolyshkin but wasn't able to get in contact.

This is open source and collaborative development, you don't have to ask a permission to work on something. Please go ahead and open your PR, and we'll go from there.

ggracechoi added a commit to ggracechoi/cli that referenced this issue Apr 26, 2024
@ggracechoi @pranjalrai4
Removed all mentions of "please" from docs and messages docker#770
509fb2f 
Co-authored-by: pranjalrai4 <pranjalrai4@users.noreply.github.com>
ggracechoi added a commit to ggracechoi/cli that referenced this issue May 1, 2024
@ggracechoi @pranjalrai4
Removed all mentions of "please" from docs and messages docker#770
be6e833 
Co-authored-by: pranjalrai4 <pranjalrai4@users.noreply.github.com>
Signed-off-by: Grace Choi <grace.54109@gmail.com>
ggracechoi added a commit to ggracechoi/cli that referenced this issue May 4, 2024
@ggracechoi
Removed all mentions of "please" from docs and messages docker#770
a0df7b9 
Signed-off-by: Grace Choi <gracechoi@utexas.edu>
Signed-off-by: Pranjal Rai <pranjalrai@utexas.edu>
@thaJeztah thaJeztah mentioned this issue May 15, 2024
Closed
@thaJeztah thaJeztah mentioned this issue Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/docs
Projects
None yet
Milestone
No milestone
4 participants
@thaJeztah @kolyshkin @ggracechoi @bsousaa