Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflicting http proxy configuration for daemon #19846

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Apr 22, 2024

Description

  • engine: rewrite dockerd systemd config to http proxy config
  • engine: rename systemd.md to proxy.md, update links

Related issues or tickets

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product area/networking Relates to anything around networking area/configuration Relates to configuring containers labels Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6df1740
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6656d7820966990008202522
😎 Deploy Preview https://deploy-preview-19846--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from thaJeztah April 22, 2024 14:40
@dvdksn dvdksn marked this pull request as ready for review April 22, 2024 14:40
@dvdksn dvdksn force-pushed the fix-conflicting-http-proxy-daemon branch from c94c305 to d88372f Compare April 22, 2024 20:36
Copy link
Contributor

@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

content/config/daemon/proxy.md Outdated Show resolved Hide resolved
@dvdksn dvdksn force-pushed the fix-conflicting-http-proxy-daemon branch from d88372f to 67e4217 Compare May 13, 2024 15:06
@dvdksn dvdksn requested a review from a team May 13, 2024 15:06
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the fix-conflicting-http-proxy-daemon branch from 67e4217 to 6df1740 Compare May 29, 2024 07:21
Comment on lines 7 to 8
- /articles/systemd/
- /engine/admin/systemd/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this page moved, so we need a another redirect from /config/daemon/systemd/

Suggested change
- /articles/systemd/
- /engine/admin/systemd/
- /articles/systemd/
- /config/daemon/systemd/
- /engine/admin/systemd/


## Custom Docker daemon options
You can configure HTTP proxy settings for the daemon in two ways:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need a short introduction on this page; we jump straight in "You can configure..", but proxy settings have been confusing for many users (most notably because there's proxy settings for the daemon, containers, build and the CLI); perhaps we should add a short intro to describe what this specific proxy is used for?

In this case, it's for the daemon itself, so networking performed by the daemon, which roughly is for i

  • Interactions with registries (authentication through the API, pushing, pulling, and searching images)
  • When running a swarm; networking and communication with other nodes in the swarm (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Relates to configuring containers area/engine Issue affects Docker engine/daemon area/install Relates to installing a product area/networking Relates to anything around networking status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent paragraph Conflicting info on configuring HTTP/HTTPS proxies
4 participants