Fix app_offline detection for some OSes #52780
Conversation
BrennanConroy
added
feature-iis
BrennanConroy
requested review from
halter73,
JamesNK and
mgravell
as code owners
|
Cross-linking #45066 |
|
Thanks @BrennanConroy for the investigation. Looks good at first glance but I'll give it a closer review today. |
ghost
added this to the 
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7202681792 |
|
Will this fix make it into the next version of .NET 8? |
|
Hi @talanc-stramit. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
No, but it will make it into the February patch probably. |
|
When will this be back ported for .net 8. We currently have aspnetcore 8.0.4 on our IIS servers and are still having this issue. |
|
8.0.4 should already have this fix. Are you sure it's this issue? Are you running on Windows Server 2012 R2? |
|
We are experiencing it on Microsoft Windows Server 2019 Standard. the bug
in mention stated that it could be happening on newer OS as well
…On Thu, May 16, 2024 at 2:10 PM Aditya Mandaleeka ***@***.***> wrote:
8.0.4 should already have this fix. Are you sure it's this issue? Are you
running on Windows Server 2012 R2?
—
Reply to this email directly, view it on GitHub
<#52780 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAN5S5UETLOY35CH46QIDTZCUHCPAVCNFSM6AAAAABASK7SJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGA4TGOJVGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
We are experiencing it on Microsoft Windows Server 2019 Standard. the bug |
|
Have you tried the workaround? #52307 (comment) File a new issue, this is a closed PR. |
|
Yes and it did not fix the problem
…On Mon, May 20, 2024 at 11:48 AM Brennan ***@***.***> wrote:
Have you tried the workaround? #52307 (comment)
<#52307 (comment)>
File a new issue, this is a closed PR.
—
Reply to this email directly, view it on GitHub
<#52780 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAN5S7E5G5IBHUOH4AM6CDZDIZPRAVCNFSM6AAAAABASK7SJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQHEYTOOJZGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I have filed a new bug for this exact same behavior.
#55807
…On Mon, May 20, 2024 at 12:08 PM Bo Denkers ***@***.***> wrote:
Yes and it did not fix the problem
On Mon, May 20, 2024 at 11:48 AM Brennan ***@***.***> wrote:
> Have you tried the workaround? #52307 (comment)
> <#52307 (comment)>
>
> File a new issue, this is a closed PR.
>
> —
> Reply to this email directly, view it on GitHub
> <#52780 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFAN5S7E5G5IBHUOH4AM6CDZDIZPRAVCNFSM6AAAAABASK7SJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQHEYTOOJZGY>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
Reverts part of #49696. It looks like calling
WaitForMultipleObjectsisn't officially supported on aHANDLEfromCreateIoCompletionPort. See https://stackoverflow.com/questions/39602908/waitforsingleobject-on-a-completion-port for some discussion on this.On Windows Server 2012 R2 it looks like
ChangeNotificationThreadends up hanging onGetQueuedCompletionStatusbecauseWaitForMultipleObjectsdoesn't work properly withm_hCompletionPortand shutdown was triggered which causes_lStopMonitorCalledto be set so we don't end up callingPostQueuedCompletionStatuswhich would unblockGetQueuedCompletionStatus.Customer issues #52307 and #52539, and possibly #52525