Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-document nullable as a valid option for WarningsAsErrors #40355

Closed
JakeYallop opened this issue Apr 7, 2024 · 1 comment · Fixed by #40965
Closed

Re-document nullable as a valid option for WarningsAsErrors #40355

JakeYallop opened this issue Apr 7, 2024 · 1 comment · Fixed by #40965
Assignees
@BillWagner
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-csharp/svc lang-reference/subsvc okr-health Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@JakeYallop
Copy link

JakeYallop commented Apr 7, 2024 •
edited by sequestor bot

Describe the issue or suggestion

Passing nullable to <WarningsAsErrors> enables errors for the set of all nullability warnings.

Documentation was added in #17094, and seems to have been accidentally removed in #22797.

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

Associated WorkItem - 255547
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Apr 7, 2024
@JakeYallop JakeYallop changed the title Re-document nullable as an option for WarningsAsErrors Re-document nullable as a valid option for WarningsAsErrors Apr 7, 2024
@gewarren gewarren removed the Pri3 label May 15, 2024
@gewarren
Copy link
Contributor

@BillWagner There was some data loss here. Maybe check the other files that were deleted in your PR to see if they had any updates while your PR was in progress, that may then have been lost?

@issues-automation issues-automation bot added dotnet-csharp/svc lang-reference/subsvc Pri1 High priority, do before Pri2 and Pri3 labels May 15, 2024
@BillWagner BillWagner self-assigned this May 16, 2024
@BillWagner BillWagner added the doc-bug Problem with the content; needs to be fixed [org][type][category] label May 16, 2024
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label May 16, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-health Content-health KR: Concerns article defects/freshness or build warnings. label May 16, 2024
@BillWagner BillWagner added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label May 16, 2024
BillWagner added a commit to BillWagner/docs that referenced this issue May 16, 2024
@BillWagner
Add "nullable" value for warnings as errors
cb913a6 
Fixes dotnet#40355

I also checked other files deleted in dotnet#22797 and nothing else was lost.
@BillWagner BillWagner mentioned this issue May 16, 2024
Merged
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels May 17, 2024
BillWagner added a commit that referenced this issue May 20, 2024
@BillWagner
Add "nullable" value for warnings as errors (#40965)
a0bef5e 
Fixes #40355

I also checked other files deleted in #22797 and nothing else was lost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillWagner BillWagner

Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-csharp/svc lang-reference/subsvc okr-health Content-health KR: Concerns article defects/freshness or build warnings. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
dotnet/docs May 2024 sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "nullable" value for warnings as errors BillWagner/docs
4 participants
@BillWagner @dotnet-bot @gewarren @JakeYallop