Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate diagnostics from showing in VS when using LSP pull diagnostics #17112

Closed
abonie opened this issue May 2, 2024 · 1 comment
Closed

Prevent duplicate diagnostics from showing in VS when using LSP pull diagnostics #17112

abonie opened this issue May 2, 2024 · 1 comment
Assignees
@abonie
Labels
Area-LSP Related to Language Server Protocol Feature Improvement
Milestone
May-2024

Comments

@abonie
Copy link
Member

abonie commented May 2, 2024

Currently the pull diagnostics endpoint is getting called multiple times (6 consistently AFAICT) and as a result duplicate diagnostics are shown. ResultId seems like it could be used to eliminate duplicate diagnostic reports, but for some reason PreviousResultId we are getting in the request is always null.
@abonie abonie added Bug Area-LSP Related to Language Server Protocol labels May 2, 2024
@abonie abonie added this to the May-2024 milestone May 2, 2024
@github-actions github-actions bot modified the milestones: May-2024, Backlog May 2, 2024
@abonie abonie modified the milestones: Backlog, May-2024 May 2, 2024
@abonie abonie self-assigned this May 2, 2024
@abonie abonie added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Feature Improvement and removed Needs-Triage Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels May 6, 2024
@abonie
Copy link
Member Author

abonie commented Jun 6, 2024

Closing this after investigation - the issue was due to experimenting with different diagnostic kinds and some debug code that was hardcoded to return multiple project context (on the _vs_getProjectContexts endpoint), both of which are multiplying the number of times the diagnostic endpoint is getting called. Nothing to fix at the moment.

@abonie abonie closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abonie abonie

Labels
Area-LSP Related to Language Server Protocol Feature Improvement
Projects
F# Compiler and Tooling
Archived in project
Milestone
May-2024
Development

No branches or pull requests
1 participant
@abonie