Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BuildRequestStarted event #10145

Open
JanKrivanek opened this issue May 16, 2024 · 1 comment
Open

Add BuildRequestStarted event #10145

JanKrivanek opened this issue May 16, 2024 · 1 comment

Comments

@JanKrivanek
Copy link
Member

Context

We need to distinguish restore is happening for the BuildCheck feature (namely for #9747)
This is not currently possible until receiving BuildEvaluationFinished.
Team decided that it's more future wise to add the full event with all the relevant info, rather than reusing BuildEvaluationStarted event.

What should be done

  • Create new BuildEventArg - named BuildRequestStarted or BuildSubmissionStarted
  • Add the followind data (they will be sourced from BuildRequestData and GraphBuildRequestData):
    • ProjectFullPath
    • TargetNames
    • Flags (note - the ClearCachesAfterBuild flag might be helpful in the future for BuildCheck dedup)
    • GlobalProps
    • SubmissionId (fro the PendBuildRequest functions)
  • Send the event through logging from a location all requests go through (probably BuildManager.PendBuildRequest - for GraphBuildRequestData and BuildRequestData)
  • Ensure proper de/serialization in BuildEventsArgReader/Writer
  • Increment binlog version, Create Binlog viewer PR (todo: give further instructions here)

Prerequisity: Verify that all the build requests go through BuildManager.PendBuildRequest and there are no other possible execution paths of build (through CLI or API) that can avoid this function

@JanKrivanek
Copy link
Member Author

The addition to the binlog might be bundled with BuildCheckTracingEventArgs de/serialization - in order to minimize formats bumps

@AR-May AR-May added the triaged label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants