Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm64: Rename AdvSimd/Sve Load/Store vector API names #102340

Open
kunalspathak opened this issue May 16, 2024 · 2 comments
Open

Arm64: Rename AdvSimd/Sve Load/Store vector API names #102340

kunalspathak opened this issue May 16, 2024 · 2 comments
Assignees
@kunalspathak
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@kunalspathak
Copy link
Member

AdvSimd

  1. Rename LoadVector128xN to LoadNxVector128
  2. Rename StoreVectorNxMAndZip to StoreVectorAndZip
    • The type on which the API is operation on can be known from parameters. As such we do not need special naming for them.
  3. Rename StoreVectorNx2 to Store
    • Same reason as point 2) above.

Sve

  1. Rename LoadNxVector to LoadNxAndUnzip

    • The operation does the unzip, similar to how it is done in AdvSimd. Compare left side operation vs. "4th quadrant" of right side.
      image

  2. Rename Store to StoreAndZip

    • Same reason as point 1) above

Discussion: #102180 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 16, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 16, 2024
@kunalspathak kunalspathak mentioned this issue May 16, 2024
Merged
@kunalspathak kunalspathak self-assigned this May 16, 2024
@kunalspathak kunalspathak added this to the 9.0.0 milestone May 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label May 16, 2024
@kunalspathak kunalspathak added untriaged New issue has not been triaged by the area owner Priority:2 Work that is important, but not critical for the release labels May 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed untriaged New issue has not been triaged by the area owner labels May 16, 2024
@kunalspathak kunalspathak added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 16, 2024
@kunalspathak
Copy link
Member Author

cc: @tannergooding @dotnet/arm64-contrib

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak kunalspathak changed the title Arm64: Rename AdvSimd and Sve Load and Store vector API names Arm64: Rename AdvSimd and Sve Load/Store vector API names May 16, 2024
@kunalspathak kunalspathak changed the title Arm64: Rename AdvSimd and Sve Load/Store vector API names Arm64: Rename AdvSimd/Sve Load/Store vector API names May 16, 2024
@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@vcsjones @kunalspathak