Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftErrorHandling: Assertion failed 'killMask == getKillSetForNode(tree)' #102349

Closed
EgorBo opened this issue May 16, 2024 · 2 comments · Fixed by #102519
Closed

SwiftErrorHandling: Assertion failed 'killMask == getKillSetForNode(tree)' #102349

EgorBo opened this issue May 16, 2024 · 2 comments · Fixed by #102519
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab Priority:2 Work that is important, but not critical for the release
Milestone

Comments

@EgorBo
Copy link
Member

EgorBo commented May 16, 2024

Fails in runtime-coreclr jitstress-random

Assert failure(PID 96937 [0x00017aa9], Thread: 2392903 [0x248347]): Assertion failed 'killMask == getKillSetForNode(tree)' in 'ErrorHandlingTests:ConditionallySetErrorTo21(ulong,int)' during 'Linear scan register alloc' (IL size 32; hash 0x763af2c5; FullOpts)


File: /Users/runner/work/1/s/src/coreclr/jit/lsrabuild.cpp:3199

Example: https://dev.azure.com/dnceng-public/public/_build/results?buildId=676435&view=ms.vss-test-web.build-test-results-tab&runId=16770882&resultId=121487&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

Build Information

Build:
Build error leg or test failing:

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "Assertion failed 'killMask == getKillSetForNode(tree)'",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=676435
Error message validated: [Assertion failed 'killMask == getKillSetForNode(tree)']
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 5/16/2024 10:53:05 PM UTC

Report

Build Definition Test Pull Request
676435 dotnet/runtime Interop/Swift/SwiftErrorHandling/SwiftErrorHandling/SwiftErrorHandling.cmd

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 1 1
@EgorBo EgorBo added the Known Build Error Use this to report build issues in the .NET Helix tab label May 16, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 16, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 16, 2024
@EgorBo EgorBo added the blocking-clean-ci-optional Blocking optional rolling runs label May 16, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo
Copy link
Member Author

EgorBo commented May 16, 2024

cc @jakobbotsch @amanasifkhalid

@amanasifkhalid amanasifkhalid self-assigned this May 17, 2024
@amanasifkhalid amanasifkhalid removed the untriaged New issue has not been triaged by the area owner label May 17, 2024
@amanasifkhalid amanasifkhalid added this to the 9.0.0 milestone May 17, 2024
@amanasifkhalid amanasifkhalid added the Priority:2 Work that is important, but not critical for the release label May 17, 2024
@amanasifkhalid amanasifkhalid added the in-pr There is an active PR which will close this issue when it is merged label May 21, 2024
amanasifkhalid added a commit that referenced this issue May 22, 2024
Fixes #102349. In LinearScan::getKillSetForNode, GT_SWIFT_ERROR_RET (which represents the regular return value, alongside the Swift error register value to be loaded) needs to be handled like GT_RETURN if Compiler::compIsProfilerHookNeeded is true, which is possible under some JitStress scenarios.
steveharter pushed a commit to steveharter/runtime that referenced this issue May 28, 2024
…2519)

Fixes dotnet#102349. In LinearScan::getKillSetForNode, GT_SWIFT_ERROR_RET (which represents the regular return value, alongside the Swift error register value to be loaded) needs to be handled like GT_RETURN if Compiler::compIsProfilerHookNeeded is true, which is possible under some JitStress scenarios.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this issue May 30, 2024
…2519)

Fixes dotnet#102349. In LinearScan::getKillSetForNode, GT_SWIFT_ERROR_RET (which represents the regular return value, alongside the Swift error register value to be loaded) needs to be handled like GT_RETURN if Compiler::compIsProfilerHookNeeded is true, which is possible under some JitStress scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged Known Build Error Use this to report build issues in the .NET Helix tab Priority:2 Work that is important, but not critical for the release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants