Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT-LLVM] PInvoke exception throwing #2454

Open
yowl opened this issue Dec 7, 2023 · 1 comment
Open

[NativeAOT-LLVM] PInvoke exception throwing #2454

yowl opened this issue Dec 7, 2023 · 1 comment
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)

Comments

@yowl
Copy link
Contributor

yowl commented Dec 7, 2023

To round off #2444 we need to codegen exception throwing in a few places

  1. PlatformNotSupportedException for lazy (not Direct PInvoke) DllImport's
  2. EntryPointNotFoundException When an attempt is made to WasmImport different functions using the same WasmImport module and function name, no import is produced.

Then uncomment the tests for these in HelloWasm.cs.
@jkotas jkotas added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label Dec 7, 2023
@SingleAccretion
Copy link

A few more items:

  • After making the PIs lazy by default, remove -sERROR_ON_UNDEFINED_SYMBOLS=0 from our emcc options.
  • Likewise with --unresolved-symbols=ignore-all with WASI.

@SingleAccretion SingleAccretion mentioned this issue Dec 11, 2023
Closed
This was referenced Jan 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yowl @jkotas @SingleAccretion