Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT-LLVM] Post-merge tasks #2472

Open
SingleAccretion opened this issue Dec 26, 2023 · 2 comments
Open

[NativeAOT-LLVM] Post-merge tasks #2472

SingleAccretion opened this issue Dec 26, 2023 · 2 comments
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)

Comments

@SingleAccretion
Copy link

SingleAccretion commented Dec 26, 2023 •
edited

This issue is intended to be a continuously updated list of things that should be done after the next upstream merge or in the merge PR itself (if necessary for a "clean" merge).

Current list:

  • Nothing!
@SingleAccretion SingleAccretion mentioned this issue Dec 26, 2023
Merged
@yowl
Copy link
Contributor

yowl commented Dec 26, 2023 •
edited

Will we be able to remove Microsoft.DotNet.ILCompiler.SingleEntry.targets, https://github.com/dotnet/runtimelab/pull/2248/files#diff-29f00866a1dc9b2d5c3acb94480513bacbc05775e9ac3dea25215287a20d979aR3 at some point?

@SingleAccretion
Copy link
Author

Will we be able to remove Microsoft.DotNet.ILCompiler.SingleEntry.targets at some point?

Not sure. It seems a fine way to share upstream code while pulling runtime pieces from NuGets for now.

@jkotas jkotas added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label Jan 5, 2024
@SingleAccretion SingleAccretion mentioned this issue Jan 10, 2024
Merged
@SingleAccretion SingleAccretion mentioned this issue Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yowl @jkotas @SingleAccretion