Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline package validator should allow breaking changes in major versions #40907

Open
Piedone opened this issue May 15, 2024 · 1 comment
Open
Labels
Area-ApiCompat untriaged Request triage from a team member

Comments

@Piedone
Copy link
Member

Piedone commented May 15, 2024

Is your feature request related to a problem? Please describe.

Baseline package validator will fail the validation between any two versions if there are breaking changes. This happens also between two major versions (e.g. when going from 1.2.3 to 2.0.0). However, according to SemVer 2.0.0, breaking changes are allowed in major versions.

Describe the solution you'd like

The validator IMO shouldn't raise validation errors when going to a greater major version (at least in a configurable way). Alternatively, it may raise a warning only.

Additional context

I noticed this when going from v9.1.1 to v10.0.0 with our Lombiq UI Testing Toolbox for Orchard Core project. I have some memory that the behavior I'm describing was actually the case before, but currently (.NET 8.0.300) it certainly isn't.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels May 15, 2024
Copy link
Contributor

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant