Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code review lesson #1043

Closed
wants to merge 1 commit into from
Closed

Added code review lesson #1043

wants to merge 1 commit into from

Conversation

eculler
Copy link
Collaborator

@eculler eculler commented Apr 8, 2022

Code Review Lesson PR

@nkorinek

Description

Adds a lesson on code review, including required images

Fixes #1042

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • The lesson is now accessible in the table of contents for the GitHub chapter of the intro course (served website locally)
  • domain/courses/intro-to-earth-data-science/git-github/github-collaboration/how-to-review-code-on-github/ leads to the new page

Checklist:

  • I have already submitted an issue and i was invited to submit a pr by an earthdatascience.org maintainer
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@nkorinek
Copy link
Member

@eculler please open this up on github.com/earthlab first, then I'll put my review there!

@eculler eculler closed this May 20, 2022
@eculler eculler deleted the code-review-lesson branch May 20, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lesson on Code Review for the GitHub Collaboration module
2 participants