Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

et.data.get_data with url and path doesn't return expected behavior #385

Open
lwasser opened this issue Jul 17, 2019 · 0 comments
Open

et.data.get_data with url and path doesn't return expected behavior #385

lwasser opened this issue Jul 17, 2019 · 0 comments

Comments

@lwasser
Copy link

lwasser commented Jul 17, 2019

Describe the bug
Currently i would expect get_data to download the data folder in the given path.
However, instead it placed the data in the given path in an earthpy-downloads dir and then returns an incorrect path. It's probably ideal to set the path for download directly in the call after url rather than force the user to set the path manually via et.data.path. also the path returned is NOT the correct one so we should fix that

this issue was brought up in this lesson: 2018-02-05-spatial-data-landing-page in the ea-python course where we use the download package. because download isn't in conda-forge we'd rather use earthpy to keep the environment simpler.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

**What Operating System Are you Running? **

  • Mac
  • Windows
  • Linux

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant