Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please package the test suite to your tarball #37

Open
mcepl opened this issue Aug 28, 2021 · 4 comments
Open

Please package the test suite to your tarball #37

mcepl opened this issue Aug 28, 2021 · 4 comments

Comments

@mcepl
Copy link

mcepl commented Aug 28, 2021

I would like to fix packaging for OpenSUSE, but your release tarball does not contain the tests directory. Could you please distribute them as well?

@greut
Copy link
Member

greut commented Aug 30, 2021

My two cents, here. As the test suite requires cmake/ctest; it doesn't seem very convenient considering the Python world.

This of course only works, if the package supports regular python unittests. If this call does not work one has to dig around checking various files in the development repository like .travis.yml or tox.ini.

https://en.opensuse.org/openSUSE:Packaging_Python#Running_tests

@xuhdev
Copy link
Member

xuhdev commented Aug 30, 2021

Could you grab the source by running

git clone --recursive https://github.com/editorconfig/editorconfig-core-py
git checkout v0.12.3

? Unfortunately, github's release page doesn't generate tarballs with submodules.

@mcepl
Copy link
Author

mcepl commented Aug 31, 2021

Just running

cmake .
export PYTHONPATH=$(pwd)
ctest -VV --output-on-failure .

got me almost working tests (see complete build log) with these failures:

[   33s] test 113
[   33s]         Start 113: star_star_over_separator7
[   33s]
[   33s] 113: Test command: /usr/bin/python3.9 "-m" "editorconfig" "-f" "star_star.in" "/home/abuild/rpmbuild/BUILD/editorconfig-core-py-0.12.3/tests/glob/b/z.c"
[   33s] 113: Test timeout computed to be: 10000000
[   33s] 113: key1=value1
[   33s] 113: key2=value2
[   33s] 113/197 Test #113: star_star_over_separator7 .................***Failed  Required regular expression not found. Regex=[^key2=value2[ 	
]*$ 33s]
[   33s] ]  0.04 sec
[   33s] key1=value1
[   33s] key2=value2
[   33s]

Do I miss some header file or something?

@xuhdev
Copy link
Member

xuhdev commented Aug 31, 2021

I just tested it on my machine and all tests passed. Could you try run git submodule update --init --recursive once to make sure the test submodule version matches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants