Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Configuration #99

Open
kevinjfoley opened this issue Apr 26, 2020 · 1 comment
Open

Global Configuration #99

kevinjfoley opened this issue Apr 26, 2020 · 1 comment

Comments

@kevinjfoley
Copy link
Contributor

I was taking a look at implementing the change requested in #97 and while the change itself is very simple, accessing the parameters that controls it is fairly difficult.

I ran into the same issue when implementing #95, of the 62 lines added in that PR, I think 55 or so were updating signatures to pass the new parameter along.

Therefore, I wanted to get opinions on refactoring things to use a config module that's available globally to access parameters. Essentially something along the lines of what is outlined in the Python programming FAQ.

I'd be happy to implement and I don't think it should take too much work, mostly just tedious changes. However I wanted to make sure you're on board for such a change @egh and get your feedback before starting any work. What do you think?

@egh
Copy link
Owner

egh commented Apr 26, 2020

Seems completely reasonable. Another option would be to bundle up everything in a config object and pass it along to the methods called, so that the method signature would not need updating every time we added a new parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants