Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESQL] SimplifyComparisonArithmetics not being correctly applied #108743

Open
not-napoleon opened this issue May 16, 2024 · 1 comment · May be fixed by #109256
Open

[ESQL] SimplifyComparisonArithmetics not being correctly applied #108743

not-napoleon opened this issue May 16, 2024 · 1 comment · May be fixed by #109256
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@not-napoleon
Copy link
Member

Elasticsearch Version

main

Installed Plugins

No response

Java Version

bundled

OS Version

n/a

Problem Description

The SimplifyComparisonArithmetics optimization rule isn't being applied everywhere we expect. We see this as test failures for cases that should be optimized by this rule. There are several related issues, this one is about failures related to using the QL Neg and Sub classes, instead of the ES|QL versions, in the mentioned optimization.

Steps to Reproduce

Run the SQL tests (soon to be ported to ES|QL)

Logs (if relevant)

No response

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants