Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Mark sensitive values as secret #9906

Open
taylor-swanson opened this issue May 16, 2024 · 8 comments
Open

[windows] Mark sensitive values as secret #9906

taylor-swanson opened this issue May 16, 2024 · 8 comments
Labels
enhancement New feature or request Integration:Windows Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Security Windows Platform Team

Comments

@taylor-swanson
Copy link
Contributor

There are two configuration values flagged in #8610 that need to be marked as secret:

  • httpjson.password
  • httpjson.token

In order to support secrets variables and validation, the package-spec version of the integration will need to be raised to 3.0.2 or higher. As a note, migrating to package-spec 3.0 or higher will more than likely trigger validation errors for fields. One of the main reasons why windows is being held back at pkg-spec 1.0.0 is due to the presence of dynamic metrics fields in the perfmon data stream. This is no longer allowed in newer versions of pkg-spec.

@taylor-swanson taylor-swanson added enhancement New feature or request Integration:Windows Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Security Windows Platform Team labels May 16, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@jlind23
Copy link
Contributor

jlind23 commented May 21, 2024

@pierrehilbert
Copy link

We discussed with @nfritts a month ago and his team should be the owner.

@jlind23
Copy link
Contributor

jlind23 commented May 21, 2024

@pierrehilbert let's make sure we have a pr for this then. @nfritts what's the right github team we should use then?

@nimarezainia
Copy link
Contributor

Should we remove the data plane team from that ownership file. I think majority of the inputs are security owned.

@pierrehilbert
Copy link

Yes we should, we are waiting to have a confirmation from @nfritts about the team we should add instead of the Data Plane team to open a PR.

@marc-gr
Copy link
Contributor

marc-gr commented May 23, 2024

Even though the upgrade to a most recent package-spec is something we should do, I wonder if we want to keep the httpjson based Splunk input. @jamiehynds what do you think? Would be something we could remove, also from the other couple integrations that have it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Windows Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Security Windows Platform Team
Projects
None yet
Development

No branches or pull requests

6 participants