-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request]: Host Metrics Tab #3788
Comments
Hi Roshan. Is this feature behind a feature flag? Is that why we're currently unsure of the release date? It looks like it made it into 8.14 before FF. |
@bmorelli25 It's not behind a feature flag. Self-managed release date is 8.14 and I believe it's on serverless already. |
@roshan-elastic I'm working on a PR to resolve this issue and during testing noticed that the Inspect option no longer appears when you click the ellipses icon. Was this removed at some point? |
hey @dedemorton , the Inspect button was never meant to be there. It was probably added by mistake. |
@crespocarlos Do you happen to know when the Inspect button was removed because it's been documented for awhile. Might be good to update earlier docs, too, so users aren't confused. |
@roshan-elastic do you remember any decision about whether or not to show Inspect? I don't feel strongly about it but it's definitely used by support engineers. Might I suggest showing it only if It's a true/false option that's passed to the Lens chart, so it's our decision on whether or not to show it. @dedemorton we can discuss this outside of the docs request. You can leave the docs that mention inspect as-is and we'll let you know if anything needs to be changed in a separate request. |
@smith @roshan-elastic @dedemorton here is the ticket that originated the charts implementation: https://github.com/elastic/obs-infraobs-team/issues/921#issue-1555322314 (internal). It says that the only action available would be something "To redirect the user to Lens". |
Hey all - thanks for looking at this. I'll be honest - I've never used Inspect and didn't realise it was an option!
Is that something a support engineer can set (and we could update Lens to automatically respect that)? If so, sounds like a good idea! Happy to do that if it's a minor thing. Maybe we could add it as a snack we can pick up next time we touch the lens chart code? @smith (cc @dedemorton @crespocarlos ) |
@smith I don't think it's a good idea to document an option that doesn't currently exist in the UI. If we add the option later, we can add the docs, too. I'll comment out the section instead of removing it entirely so that it'll be easy to add it back in later. As an aside, I would not recommend hiding this feature behind a feature flag. IMO every caveat we need to document degrades the scannability and ultimately the quality of the docs. |
Description
To reduce the clutter in our 'overview' tab per host (example) we will be:
FYI this host view is the template for all future 'resource' views (e.g. containers, kubernetes pods etc). We're gradually migrating things over to use this template
Resources
PR
Which documentation set does this change impact?
Stateful and Serverless
Feature differences
Identical in serverless/stateful
What release is this request related to?
8.14
Collaboration model
The documentation team
Point of contact.
Main contact: @roshan-elastic
Stakeholders: @jennypavlova @crespocarlos
The text was updated successfully, but these errors were encountered: