Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Add integration testing or otherwise figure out how best to test browser code #2

Open
benogle opened this issue Aug 2, 2015 · 3 comments

Comments

@benogle
Copy link
Contributor

benogle commented Aug 2, 2015

It seems like the cleanest way to test browser code is to start the app in a totally separate process like we're doing in atom: https://github.com/atom/atom/tree/master/spec/integration

To me, it seems the hardest part of this is figuring out the right way to download and use chromedriver

  • if run standalone in a lib without electron-prebuilt, it needs to pull down chromedriver for it's electron version
  • If run in an app with electron-prebuilt, it needs to pull down or use the chromedriver for the app's electron

Could build something like (or add on to) https://github.com/maxogden/electron-download to download the correct chromedriver.

cc @jlord @kevinsawicki

@kevinsawicki
Copy link

Yeah, https://github.com/atom/grunt-download-electron/ supports downloading chromedriver, added by @maxbrunsfeld

I think a library just for chromedriver-ing sounds good to me.

@benogle
Copy link
Contributor Author

benogle commented Aug 3, 2015

I wanted to avoid requiring the grunt dep, so maybe an electron-download-chromedriver could be the right thing.

@kevinsawicki
Copy link

I wanted to avoid requiring the grunt dep

Sounds good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants