Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

v0.8.0 fails to install atom-shell < v0.13.0 due to missing 'arch' in release filename #12

Open
banderson opened this issue Jun 21, 2014 · 1 comment

Comments

@banderson
Copy link

Background: I'm starting a new project and included the latest version of this plugin. It works fine for installing atom-shell v0.13.0+, but releases prior to that did not include '-arch' suffix in the release filename, and this change causes it to fail.

Repro: running v0.8.0 of this plugin and installing atom-shell v0.12.7 results in this error:
Cannot find atom-shell-v0.12.3-darwin-x64.zip in atom-shell v0.12.3 release

When you look at the github releases, you'll see the actual filename is atom-shell-v0.12.3-darwin.zip.

I switched back to ~0.7.0 to get this working, but I can submit a PR to make this backwards compatible if you'd like.

-Ben

@kevinsawicki
Copy link
Contributor

A PR would be great, thanks for offering 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants