Issue with prereleases coming from nuget.semanticversion #85
Comments
This feature was only very recently added, are you using the latest version of erry'thing? |
grunt-electron-installer at 1.1.0, yeah. |
So, at what point were prereleases added to nuget? It looks like the nuget in squirrel.windows hasn't really been tied to the core since may? (Forked by Haacked then, and paul has 3 new commits since then locally). Edit: For the time being, I was able to replace the version I passed to the grunt config for the task with one replacing |
Prereleases in NuGet have been there forever, but we recently enabled them in Squirrel.Windows (previously Squirrel used the prerelease tag for its own purposes). Atom is using the |
Sure thang 👍 |
That worked O.o |
I think the word |
Well, their docs specify that pretty much whatever should be ok there. I'll play with it more, see if maybe capitalization has a role? All of their examples are lower case, now that I think of it. |
For what it's worth, I think the semanticversion.parse() regex in the nuget version being used by squirrel must be wrong, because it seems to fail whenever I use upper case. E.g., 1.0.0-QA41 fails, but 1.0.0-qa41 succeeds. |
So we're trying to build prerelease versions with names like
3.2.1-RC4
, but nuget semver is throwing weird errors where it strips out most of the version number.Now, in nuget's semver specs it says soemthing like
3.2.1-RC.4
is not allowed, but something without the period in the component after the-
is. This module is even splitting on that-
, and removing all of the periods in the tailing component of the version to match that. It appears however that they're somehow stripping down everything before the -, and then their semver parse is stripping off the text before numbers. Is this a known issue (with nuget, squirrel, grunt-electron-installer, or commonly in end-user code)?The text was updated successfully, but these errors were encountered: