Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Allow custom template.nuspec #89

Open
fasterthanlime opened this issue Dec 12, 2015 · 4 comments
Open

Allow custom template.nuspec #89

fasterthanlime opened this issue Dec 12, 2015 · 4 comments

Comments

@fasterthanlime
Copy link

Clearly marked as advanced feature, yada yada, even undocumented for now if maintainers wish, but there's two issues preventing windows installer builds on Linux in the current template:

ideally grunt-electron-installer would work around these out of the box, but in the meantime being able to pass a path to a template.nuspec file to be used would be very very cool.

@fasterthanlime
Copy link
Author

Implemented here: master...itchio:patch-custom-nuspec — waiting for Squirrel.Windows changes to land before opening PR

@anaisbetts
Copy link
Contributor

The custom nuspec might be interesting, but we should also make grunt-electron-installer silently fix this up

@fasterthanlime
Copy link
Author

we should also make grunt-electron-installer silently fix this up

Right, but I saw no good immediate option (either use regular expressions and risk overshooting, or parse xml + re-emit it and then you have a dependency on an XML parser, an XML generator :/)

Or.. two sets of template? Or make the whole path list be a 'variable' in the template and generate that from the task itself?

The part that annoys me the most is having to drop 'LICENSE' because of that NuGet bug that only happens on Mono. 😢

@anaisbetts
Copy link
Contributor

The part that annoys me the most is having to drop 'LICENSE' because of that NuGet bug that only happens on Mono. 😢

Yeah :-/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants