Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint is not returning the correct electron version number #88

Open
ThorstenHans opened this issue Sep 30, 2016 · 0 comments
Open

Lint is not returning the correct electron version number #88

ThorstenHans opened this issue Sep 30, 2016 · 0 comments

Comments

@ThorstenHans
Copy link

When linting an existing App. Electron's current version is grabbed from https://atom.io/download/atom-shell/index.json.

From the JSON array, the first element is returned which must not be the recent version. Currently it's treating 1.3.7 as the current version because it's the first element in the array. Version 1.4.1 is the second one in the array.

So the lint-helpers should pay respect to the version property of each release listed in the array/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants