-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [time-picker] input elements with default id in range #16808
base: dev
Are you sure you want to change the base?
fix(components): [time-picker] input elements with default id in range #16808
Conversation
👋 @xuyimingwork, seems like this is your first time contribution to element-plus.
|
Hello @xuyimingwork, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
27f0c2f
to
6c2a104
Compare
In previous version, I change input to el-input, with style and some function change, it actually worked. Directly using useFormItemInputId in picker.vue may cause some problem, So, I change to use a component to provide range input id info. |
Complete test cases for this |
8effe92
to
1bdf495
Compare
🧪 Playground Preview: https://element-plus.run/?pr=16808 |
fix time-picker type range input elements without default id value closed element-plus#16802
add input id check for time-picker in range adjust non range test cases to right place closed element-plus#16802
1bdf495
to
b758d1c
Compare
fix time-picker type range input elements without default id value
closed #16802
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.