Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate or fix (node) v8::ObjectTemplate::Set() with non-primitive values is deprecated #5

Open
eljefedelrodeodeljefe opened this issue Jun 20, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@eljefedelrodeodeljefe
Copy link
Owner

Test addon_7 produces the below. Doubtful that is an issue of this lib

(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x2e3836bc9e59 <JS Object>#0#
    1: .node [module.js:568] [pc=0x28891fc729c4] (this=0x3f1566960b31 <an Object with map 0x2d9076e17d41>#1#,module=0x1a9bd00924c1 <a Module with map 0x2d9076e18319>#2#,filename=0x1a9bd0092471 <String[51]: /Users/jefe/repos/platform-tools/build/addon_7.node>)
    2: load [module.js:458] [pc=0x28891fb34332] (this=0x1a9bd00924c1 <a Module with map 0x2d9076e18319>#2#,filename=0x1a9bd0092471 <String[51]: /Users/jefe/repos/platform-tools/build/addon_7.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:417] [pc=0x28891fb33e5d] (this=0x2e3836b04189 <undefined>,module=0x1a9bd00924c1 <a Module with map 0x2d9076e18319>#2#,filename=0x1a9bd0092471 <String[51]: /Users/jefe/repos/platform-tools/build/addon_7.node>)
    4: _load [module.js:409] [pc=0x28891fb2fa42] (this=0x3f1566960ae9 <JS Function Module (SharedFunctionInfo 0x106b7c523ec1)>#3#,request=0x1a9bd0091cc9 <String[51]: /Users/jefe/repos/platform-tools/build/addon_7.node>,parent=0x1a9bd0090779 <a Module with map 0x2d9076e18319>#4#,isMain=0x2e3836b04299 <false>)
    5: require [module.js:468] [pc=0x28891fb3ddd3] (this=0x1a9bd0090779 <a Module with map 0x2d9076e18319>#4#,path=0x1a9bd0091cc9 <String[51]: /Users/jefe/repos/platform-tools/build/addon_7.node>)
    6: require(aka require) [internal/module.js:20] [pc=0x28891fb3db06] (this=0x2e3836b04189 <undefined>,path=0x1a9bd0091cc9 <String[51]: /Users/jefe/repos/platform-tools/build/addon_7.node>)
    7: /* anonymous */ [/Users/jefe/repos/platform-tools/test/fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js:1] [pc=0x28891fc86940] (this=0x1a9bd00907c9 <an Object with map 0x3f9c40907bc9>#5#,exports=0x1a9bd00907c9 <an Object with map 0x3f9c40907bc9>#5#,require=0x1a9bd0091b31 <JS Function require (SharedFunctionInfo 0x106b7c554279)>#6#,module=0x1a9bd0090779 <a Module with map 0x2d9076e18319>#4#,__filename=0x1a9bd00906f1 <String[109]: /Users/jefe/repos/platform-tools/test/fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>,__dirname=0x1a9bd0091ac9 <String[100]: /Users/jefe/repos/platform-tools/test/fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan>)
    8: _compile [module.js:541] [pc=0x28891fb3ce30] (this=0x1a9bd0090779 <a Module with map 0x2d9076e18319>#4#,content=0x1a9bd00916f9 <String[65]\: module.exports = require(`${process.cwd()}/build/addon_7.node`);\n>,filename=0x1a9bd00906f1 <String[109]: /Users/jefe/repos/platform-tools/test/fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>)
    9: .js [module.js:550] [pc=0x28891fb3592b] (this=0x3f1566960b31 <an Object with map 0x2d9076e17d41>#1#,module=0x1a9bd0090779 <a Module with map 0x2d9076e18319>#4#,filename=0x1a9bd00906f1 <String[109]: /Users/jefe/repos/platform-tools/test/fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>)
   10: load [module.js:458] [pc=0x28891fb34332] (this=0x1a9bd0090779 <a Module with map 0x2d9076e18319>#4#,filename=0x1a9bd00906f1 <String[109]: /Users/jefe/repos/platform-tools/test/fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>)
   11: tryModuleLoad(aka tryModuleLoad) [module.js:417] [pc=0x28891fb33e5d] (this=0x2e3836b04189 <undefined>,module=0x1a9bd0090779 <a Module with map 0x2d9076e18319>#4#,filename=0x1a9bd00906f1 <String[109]: /Users/jefe/repos/platform-tools/test/fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>)
   12: _load [module.js:409] [pc=0x28891fb2fa42] (this=0x3f1566960ae9 <JS Function Module (SharedFunctionInfo 0x106b7c523ec1)>#3#,request=0x106b7c5e3621 <String[74]: ../fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>,parent=0x98995c4269 <a Module with map 0x2d9076e18319>#7#,isMain=0x2e3836b04299 <false>)
   13: require [module.js:468] [pc=0x28891fb3ddd3] (this=0x98995c4269 <a Module with map 0x2d9076e18319>#7#,path=0x106b7c5e3621 <String[74]: ../fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>)
   14: require(aka require) [internal/module.js:20] [pc=0x28891fb3db06] (this=0x2e3836b04189 <undefined>,path=0x106b7c5e3621 <String[74]: ../fixtures/sources/addons/node-addon-examples/7_factory_wrap/nan/addon.js>)
   15: /* anonymous */(aka /* anonymous */) [/Users/jefe/repos/platform-tools/test/async/addon.js:141] [pc=0x28891fc863d7] (this=0x2e3836b04189 <undefined>,err=0x2e3836b04101 <null>)
   16: /* anonymous */(aka /* anonymous */) [/Users/jefe/repos/platform-tools/lib/platform_tools.js:337] [pc=0x28891fc721f5] (this=0x2e3836b04189 <undefined>)
   17: _combinedTickCallback(aka _combinedTickCallback) [internal/process/next_tick.js:~65] [pc=0x28891fc7ed20] (this=0x2e3836b04189 <undefined>,args=0x2e3836b04189 <undefined>,callback=0x1a9bd008f2b9 <JS Function process.nextTick (SharedFunctionInfo 0x187654644c69)>#8#)
   18: _tickCallback [internal/process/next_tick.js:98] [pc=0x28891fb6d48b] (this=0x2e3836be0e51 <a process with map 0x3f9c409115c9>#9#)
=====================


==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: MyObject::Init()
 3: InitAll(v8::Local<v8::Object>, v8::Local<v8::Object>)
 4: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x28891fa0961b
 9: 0x28891fc729c4
@eljefedelrodeodeljefe eljefedelrodeodeljefe self-assigned this Jun 20, 2016
@eljefedelrodeodeljefe eljefedelrodeodeljefe added this to the 1.0 milestone Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant