Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy package hints #19

Open
adamjakab opened this issue Jun 1, 2013 · 0 comments
Open

deploy package hints #19

adamjakab opened this issue Jun 1, 2013 · 0 comments

Comments

@adamjakab
Copy link

I really like elkuku's work and I think this project has excellent potentials.

LNX+J!2.5.11+EC0.0.19: I had a problem deploying packages so i followed the flow and I have identified 2 bugs:

file: com_easycreator/helpers/deployer/ftp.php

  1. I had special characters in my ftp password like "[" and "]" and probably others but on connection @line: ~260 method: connect() the value of $credentials->pass is already cleand up (stripping some special chars) missing at least these two characters (and probably some others) - since i was in a rush i changed my ftp password and this one was resolved but this is a bug to be corrected surely. Moreover, even though it was trying to connect with bad pwd and failing, exception in @line:~270 is NOT thrown - so i took some time to figure this out because i did not get error msg "Unable to connect to FTP server".

  2. @line:~47 method deployPackage: there is something fishy because after having chdir-ed into downloads dir($this->ftp->chdir($this->credentials->downloads)) which should throw an error on failure, the store command included the same path again ($this->ftp->store($file, $this->credentials->downloads.'/'.$fName)) - failing miserably.
    changing that to: $this->ftp->store($file, $fName) resolves the problem immediately.
    Also, I just noticed that the chdir command put inside the loop this way requires that you put "/" in front of your download dir otherwise if you try to deploy multiple packages it will fail from the second one on.

hope it helps
Thanks elkuku!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant