Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cycle 0 list = [] ? #149

Open
bitterjug opened this issue Jul 1, 2021 · 1 comment
Open

Cycle 0 list = [] ? #149

bitterjug opened this issue Jul 1, 2021 · 1 comment

Comments

@bitterjug
Copy link

If the cycle length is zero, shouldn't we be returning a list of length zero?

list-extra/src/List/Extra.elm

Line 205 in 7ae12a5

list

@Chadtech
Copy link
Collaborator

Chadtech commented Jul 1, 2021

Yes, and I think that is the case, because cycleLength comes from the List.length of input list. So when cycleLength is zero, the input list is returned, which was necessarily an empty list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitterjug @Chadtech