Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install failed on Node.js 4.1.1 #38

Open
luckymark opened this issue Oct 14, 2015 · 1 comment
Open

Install failed on Node.js 4.1.1 #38

luckymark opened this issue Oct 14, 2015 · 1 comment
Labels

Comments

@luckymark
Copy link

part of error messages:
...

pty.js@0.2.13 install /Users/luckystar/WebstormProjects/kisscc/app/node_modules/dbgmits/node_modules/pty.js
node-gyp rebuild

CXX(target) Release/obj.target/pty/src/unix/pty.o
In file included from ../src/unix/pty.cc:20:
../node_modules/nan/nan.h:324:27: error: redefinition of
'NanEnsureHandleOrPersistent'
NAN_INLINE v8::Local NanEnsureHandleOrPersistent(const v8::Local &val) {
^
../node_modules/nan/nan.h:319:17: note: previous definition is here
v8::Handle NanEnsureHandleOrPersistent(const v8::Handle &val) {
^
...

@enlight enlight added the bug label Oct 14, 2015
@enlight
Copy link
Owner

enlight commented Oct 16, 2015

Upon further investigation pty.js v0.3 has been updated to support NAN v2 which means it should be compatible with Node 4.x.x. I don't think there were any actual changes to the public API of pty.js so upgrading to the latest pty.js should be as simple as bumping up the version in the package.json and rerunning npm install. Unfortunately I won't have access to a machine where I can actually test this change for another 6 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants