Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache state in localStorage #65

Open
baransu opened this issue Jun 22, 2017 · 4 comments
Open

Cache state in localStorage #65

baransu opened this issue Jun 22, 2017 · 4 comments
Assignees

Comments

@baransu
Copy link
Contributor

baransu commented Jun 22, 2017

When we're for some reason reloading page, we lose all state and in the worst case we have to wait 5s for the new state from the server. My idea is to cache state in localStorage and when we're reloading page it will be loaded from cache. If observed node crashes and we're reloading page to reconnect we don't want to display old, cached state so we have to wipe it on WebSocket connection crash.
It's a small change but can be nice quality of life improvement.

@baransu baransu added this to the 0.8 milestone Jun 22, 2017
@baransu baransu self-assigned this Jun 22, 2017
@arkgil
Copy link
Contributor

arkgil commented Jun 24, 2017

I like the idea of improving our UX 👍 The crucial part here is to make sure old data is cleaned up.

@michalslaski
Copy link
Member

If I don't have any browser tabs open, then I restart ./erlangpl script and then again open the browser, the local cache is not cleaned up. The only way to clean it up is to have a tab opened, so that it can discover the WebSocket connection crash. This may be confusing.

@baransu
Copy link
Contributor Author

baransu commented Jun 28, 2017

We're storing start timestamp in ets and then sending it to client on new connection so client should clean when connection crashes or ./erlangpl was restarted.

@baransu
Copy link
Contributor Author

baransu commented Jul 27, 2017

I've disabled caching for now: 476688b so it' no longer blocking release.

This issue is still relevant and definitely needs better solution. Unfortunately I don't have time to focus more on Erlang Perf Lab right now, but I hope I'll find more time in the future to work on parts that needs improvement to make it better software :)

@baransu baransu removed this from the 0.8 milestone Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants