Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another version of escope #127

Open
vincentdchan opened this issue May 4, 2018 · 1 comment
Open

Another version of escope #127

vincentdchan opened this issue May 4, 2018 · 1 comment

Comments

@vincentdchan
Copy link

vincentdchan commented May 4, 2018

Hi, I am writing a plugin for webpack to do deep socpe analysis. I modified escope and wrapped it into Typescript. just see src/

There are several difference:

  • TypeScript
  • scopes are split into several files
  • ImportManager and ExportManager are added to ModuleScope for tree shaking in webpack
  • export default function () { ... } will not be regarded as scope in escope, but my plugin will analyze it

As an open source project I try to submit PR to escope and use escope directly. There is no need to make a new lib. So I just want to ask will escope accept these changes. If it's OK, I will submit a PR.

@brettz9
Copy link

brettz9 commented Apr 26, 2020

By "scopes are split into several files", do you mean it builds a structure which can represent a whole application? That sounds very good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants