Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control-Z working only on English keyboard #8003

Open
kirillrocks opened this issue May 10, 2024 · 8 comments
Open

Control-Z working only on English keyboard #8003

kirillrocks opened this issue May 10, 2024 · 8 comments

Comments

@kirillrocks
Copy link

kirillrocks commented May 10, 2024

Hey!

I am using 4 different languages, but for Control-Z to work, I always have to go back to the English layout. On Russian/Ukrainian/Dutch it is not working.

This is the only tool that has that limitation.

@Mrazator
Copy link
Collaborator

Hi @kirillrocks! Does it mean that when you are on English layout, it works just sometimes or it always works with English layout, but not the other ones mentioned? Asking due to the comment in #5375 (comment)

@Mrazator
Copy link
Collaborator

Could you reproduce the issue on excalidraw.com? Trying out dutch layout on Chrome, MacOS (command + z) and I can't reproduce it.

@kirillrocks
Copy link
Author

Hey @Mrazator. Can reproduce on Excalidraw.com.

There is another issue with command+z that sometimes it just losing it's memory (even with manually clicking on redo/undo). But this issue is specific to the language.

I am on Windows10, Chrome(latest version).

@kirillrocks
Copy link
Author

@Mrazator, can you try the non-Latin alphabet? Maybe Cyrilic?

@Mrazator
Copy link
Collaborator

I could try with non-Latin but not sure if I will be pressing the right keys :) Could you please provide us with explicit repro steps?

@Mrazator
Copy link
Collaborator

Mrazator commented May 10, 2024

Similar to Dutch, switching to Russian layout works as expected for me, with "Z" being in the same position in both. Interestingly Dutch-Belgian has intertchanged "Z" with "W", so it instead closes the tab. I suspect that some combination of pressed keys (i.e. due to switching languages) could lead to refresh (like CTRL+R), but I guess you would notice the tab would close / reload, unless it's some kind of silent refresh.

@kirillrocks
Copy link
Author

That is strange, but I work in Linear and ClickUp, and it seems to work there in every language. How can I help you to reproduce the issue?

@dwelle
Copy link
Member

dwelle commented May 10, 2024

@kirillrocks in order to identify the issue, we need to separate the "ctrl-z doesn't work on non-english layout" from "undo sometimes doesn't work at all (from UI)".

If you can reproduce the latter, please open up a new issue with steps. Also make sure that your browser isn't being reloaded as @Mrazator suggested could be happening.

As for making the shortcut work on non-english layout, we'll investigate what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants