Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit config.action_mailer.default_url_options in next release of Rails #211

Closed
stevepolitodesign opened this issue Feb 28, 2024 · 3 comments
Assignees
Labels

Comments

@stevepolitodesign
Copy link
Contributor

Once rails/rails#51191 is in the next Rails release, we can omit the following line:

environment "config.action_mailer.default_url_options = { host: 'localhost', port: 3000 }", env: 'development'

@stevepolitodesign
Copy link
Contributor Author

@excid3 feel free to close this or move this to a backlog. I just wanted to bring it to your attention 👍

@excid3 excid3 added the blocked label Feb 28, 2024
@excid3
Copy link
Owner

excid3 commented Feb 28, 2024

Great improvement @stevepolitodesign 👍

@excid3 excid3 self-assigned this Feb 28, 2024
@excid3
Copy link
Owner

excid3 commented Mar 22, 2024

Going to close this for now since we'll still need this line for older Rails version unless we drop support for them at some point.

@excid3 excid3 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants