Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https option #199

Open
oscl opened this issue Jun 17, 2018 · 8 comments
Open

Add https option #199

oscl opened this issue Jun 17, 2018 · 8 comments

Comments

@oscl
Copy link

oscl commented Jun 17, 2018

Hi Dev,
Today, I was going to create an Express based website on my cloud account. I knew that the providers also provides free SSL for my websites. So, after deployment, I tried to visit my website using https(https://my domain.tld) but the server says that they can't provide secure connection and returns invalid response. Because the server is actually started for http protocol. When I searched about it on Google, everyone says that I have to edit the www file using a text editors manually. If I have to do things manually, then what is the job of Express generator ?

If the Dev team could add a flag like --https then we could use something like Express --view=ejs --https and it'll be more awesome!

@dougwilson
Copy link
Contributor

Pull requests welcome to add the feature 👍

@dougwilson dougwilson changed the title One of the biggest feature is missing on Express generator.... 😱😱😱 Add https option Jun 17, 2018
@oscl
Copy link
Author

oscl commented Jun 17, 2018 via email

@dougwilson
Copy link
Contributor

I'm not sure I understand your question. As for making a pull request, this project is open source and contains what was contributed. You're welcome to contribute the feature you're looking for, but if you're not sure how or have the time, you're welcome to find someone else who has the time / skills to get it added 👍

@oscl
Copy link
Author

oscl commented Jun 18, 2018

I'm not that much well learnt.
If anyone could add that awesome feature, I'll describe the thing for them.

Normally, when we start a project by generating Express using command like express --view=ejs, It just simply creates an Express app in the folder with ejs chosen as view engine. I'm not talking about EJS okay...
But the problem is that if express-generator users install Express on a cloud computing server (which server a subdomain for him with https enabled), then he can surely visit the newly created website using address like http://sub.domain.com but not https://sub.domain.com because codes from www.js are creating Web server for only http. Not for https.

If Express generator has another feature like an https flag,
Express-generator user could simply run a command like Express --view=ejs --https for generating Express files with the code of https enabled server.

Please....
If anybody could add this feature, add it.
Please..

@jonnyka
Copy link

jonnyka commented Jun 19, 2018

@dougwilson I've created a PR for the issue, can you check please? thanks

@slidenerd
Copy link

My suggestion is to NOT add this feature.

  • HTTPS is supposed to be handled by a web-server like NGINX
  • OR the elastic load balancer
  • The application should keep itself free of attaching PEM certificates and stuff

@kingadimu
Copy link

@oviecodes
Copy link

We could allow the user choose an https option through the command line then the application(express-generator) Could generate an SSL certificate if https option was chosen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants