Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running tests locally fails #308

Open
p4nu opened this issue May 28, 2022 · 0 comments · May be fixed by #309
Open

Running tests locally fails #308

p4nu opened this issue May 28, 2022 · 0 comments · May be fixed by #309
Labels
tests

Comments

@p4nu
Copy link
Contributor

p4nu commented May 28, 2022 •
edited

This is due when node-sass-middleware version 0.11.0 is installing node-sass. This is now deprecated and should be updated to use dart-sass (currently named as sass) according to their official npm docs: https://www.npmjs.com/package/node-sass

https://www.npmjs.com/package/sass

image

Related to #296
p4nu added a commit to p4nu/expressjs-generator that referenced this issue May 28, 2022
@p4nu
(Chore) Update node-sass-middleware to v1.0.1
c8e437a 
This closes issues:
Running tests locally fails expressjs#308
and
Sass Generator not working out of the box expressjs#296
@p4nu p4nu linked a pull request May 28, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Chore) Update node-sass-middleware to v1.0.1 p4nu/expressjs-generator
2 participants
@p4nu @import-brain