[React 19]: eslint-plugin-react-compiler gives false positive if hook takes generics

[SimenB]

Summary

(Not sure if this should be filed under React 19?)

The following code triggers Hooks may not be referenced as normal values, they must be called. See https://react.dev/reference/rules/react-calls-components-and-hooks#never-pass-around-hooks-as-regular-values

interface Data {}

function useHello() {
  const queryClient = useQueryClient();

  return useMutation<Data>({});
}

(useQueryClient and useMutation coming from @tanstack/react-query, fwiw)

Either removing the <Data> generic, or the preceding useQueryClient resolves the error.

This is using eslint-plugin-react-compiler@0.0.0-experimental-e04a001-20240515

---

Anyways, I'm super excited that you've finally open sourced this, and look forward to using it!

(I do wonder why pretty-format@24 is used in the babel plugin tho 👀 very old!)

[josephsavona]

Thanks for posting this, this looks like an issue with which parser we use for TS code in the linter.

[NMinhNguyen]

I can confirm that #29081 appears to have fixed this issue :)

[poteto]

yep this was just fixed in #29081, thanks for reporting!