Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React 19]: eslint-plugin-react-compiler defines no main in its package.json #29068

Closed
SimenB opened this issue May 15, 2024 · 2 comments · Fixed by #29072
Closed

[React 19]: eslint-plugin-react-compiler defines no main in its package.json #29068

SimenB opened this issue May 15, 2024 · 2 comments · Fixed by #29072
Labels
React 19

Comments

@SimenB
Copy link
Contributor

SimenB commented May 15, 2024

Summary

require('eslint-plugin-react-compiler') fails - one has to do require('eslint-plugin-react-compiler/dist/index.js') instead. Happy to send a PR for this once you publish the source code.

Using 0.0.0-experimental-e04a001-20240515
@cpojer cpojer mentioned this issue May 15, 2024
Merged
@cpojer
Copy link
Contributor

cpojer commented May 15, 2024

PR: #29072

@SimenB
Copy link
Contributor Author

SimenB commented May 15, 2024

Hey Christoph! 😀 Didn't notice the source code was out - good stuff 👍

poteto pushed a commit that referenced this issue May 15, 2024
@cpojer
Add a main field to eslint-plugin-react-compiler, fixes #29068. (#…
cfeb491 
…29072)

## Summary

The main field is missing, this fixes it.

Fixes #29068.

## How did you test this change?

Manually patched the package and tried it in my codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
React 19
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a main field to eslint-plugin-react-compiler, fixes #29068. cpojer/react
2 participants
@cpojer @SimenB