Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema Draft 8 implementation #49

Open
halex2005 opened this issue Oct 31, 2019 · 6 comments
Open

JSON Schema Draft 8 implementation #49

halex2005 opened this issue Oct 31, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@halex2005
Copy link

Hi!
There is new JSON Schema draft available here: http://json-schema.org/specification-links.html#2019-09-formerly-known-as-draft-8
Does this library needs changes?
Actually, I don't read this draft yet. May be someone tell: does this library already implements new draft or it needs some changes?

I suggest you create roadmap for the changes, if necessary.
It could help the community to focus what's really needed and track the overall progress.

@Eomm
Copy link
Member

Eomm commented Oct 31, 2019

Thanks for the advice

There are a couple of things that are really breaking changes like:

  • "definitions" renamed to "$defs"
  • "dependencies" renamed to "dependentRequired"

Plus new keywords

Help is always appreciate 💪🏻

// cc @mcollina per fast-json-stringify

@aboutlo
Copy link
Collaborator

aboutlo commented Nov 1, 2019

good point @halex2005 IMO until we don't have a validator eg. AJV there isn't too much value.
On the other hand in order to support draft 7 and draft 8 we need to rework the implementation and polishing the tests to make clear what we support on each version.

They are talking here as well: ajv-validator/ajv#1082

@aboutlo aboutlo added the enhancement New feature or request label Nov 1, 2019
@aboutlo
Copy link
Collaborator

aboutlo commented Jun 3, 2020

A more updated issue on AJV side: ajv-validator/ajv#1198

@mcollina
Copy link
Member

mcollina commented Jun 3, 2020

fast-json-stringify does not implement the latest draft.

@onosendi

This comment was marked as off-topic.

@mcollina
Copy link
Member

When will it implement the latest draft?

When somebody will PR that in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants