Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom types in error messages are missing the leading ":" #73

Open
emilsoman opened this issue Dec 31, 2020 · 1 comment
Open

Atom types in error messages are missing the leading ":" #73

emilsoman opened this issue Dec 31, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@emilsoman
Copy link
Member

emilsoman commented Dec 31, 2020

This is because we depend on to_string to print types and that removes : from atoms. One easy solution could be - parse atom types as strings and store them as ":foo" instead of :foo.

@emilsoman emilsoman added the bug Something isn't working label Dec 31, 2020
@polvalente
Copy link
Contributor

@emilsoman this solution is good, but I think we should convert the atom to string only after "instantiating" the atom, so we fill the Atom Table properly. Otherwise, it might be the case in which the compiler handles a program which will always crash due to overflowing the Atom Table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants