Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace minerID abi.ActorID parameters with address type #92

Open
anorth opened this issue May 18, 2020 · 0 comments
Open

Replace minerID abi.ActorID parameters with address type #92

anorth opened this issue May 18, 2020 · 0 comments

Comments

@anorth
Copy link
Member

anorth commented May 18, 2020

A bunch of functions in proofs.go accept a miner ID parameter as an actor ID. This id is then turned into a "prover id" by creating an ID address and then extracting its payload. But in implementations, all call sites started out with an ID address in the first place and had to extract the actor ID from it in order to call these functions.

Change the functions to just accept an address, and perhaps add a precondition that it is of protocol address.ID in order to fail fast if it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant