Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasWeakQuorumFor never called #233

Open
Stebalien opened this issue May 16, 2024 · 1 comment
Open

HasWeakQuorumFor never called #233

Stebalien opened this issue May 16, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
Milestone 0: F3 A...

Comments

@Stebalien
Copy link
Member

Nothing calls HasQeakQuorumFor, or ever reads chainSupport.hasWeakQuorum. Should we remove this? Or are we missing a part of the protocol.
@Stebalien Stebalien added the bug Something isn't working label May 16, 2024
@anorth
Copy link
Member

anorth commented May 16, 2024

Defer this for a bit, it's currently unclear whether we'll end up calling it as part of skipping rounds. It was also in the FIP for another reason until very recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
F3
Status: No status
Milestone
Milestone 0: F3 Alpha Code Freeze
Development

No branches or pull requests
3 participants
@Stebalien @anorth @jennijuju