Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test invalid converge cases #237

Open
2 tasks
Tracked by #249
Stebalien opened this issue May 16, 2024 · 0 comments
Open
2 tasks
Tracked by #249

Test invalid converge cases #237

Stebalien opened this issue May 16, 2024 · 0 comments
Labels
testing Related to testing and validation

Comments

@Stebalien
Copy link
Member

It looks like we're not testing the following converge cases:

  • Swaying vote in converge round (we never hit ⚠️ swaying from %s to %s by CONVERGE. I'm not actually sure what this means, but we should be hitting this log, right?
  • Try to converge to bottom with a bogus justification (not legal in the protocol, but we should test this case to make sure we correctly reject it).
@Stebalien Stebalien added the testing Related to testing and validation label May 16, 2024
@masih masih mentioned this issue May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Related to testing and validation
Projects
F3
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stebalien